Fix export channel check for updated DirectSpeakers plugin #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
firthm01
approved these changes
Aug 13, 2021
This fixes a regression after the DirectSpeakers plugin was updated to support more channel layouts. The max value of paramSpeakerLayout had not been updated to reflect the new layout count. As the comment above the changed code suggests, we should consolidate this stuff in one place, but leaving that for now as this is an urgent fix.
rsjbailey
force-pushed
the
directspeakers-export-fix
branch
from
f8e03da to
589d589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression after the DirectSpeakers plugin was updated to support
more channel layouts. The max value of paramSpeakerLayout had not been updated
to reflect the new layout count. As the comment above the changed code suggests, we should consolidate
this stuff in one place, but leaving that for now as this is an urgent fix.