Change how unspecified ... arguments are passed to other functions (#443)

* Change how unspecified `...` arguments are passed to other functions
Fixes #442

* news

Author: strengejacke

NEWS.md

@@ -15,6 +15,11 @@ Minor changes
 * `report` now supports reporting of BayesFactor objects with variables of class `BFBayesFactor`.
 * `report_sample()` now suggests valid column names for misspelled columns in the `select`, `by`, `weights` and `exclude` arguments.
 
+Bug fixes
+
+* Fixed issues with incorrectly passing additional arguments to downstream
+  functions in `report()` for `htest` objects.
+
 # report 0.5.8
 
 New features

R/report_htest_chi2.R

@@ -17,7 +17,7 @@
     estimate <- names(table)[1]
     rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
 
-    args <- list(table, rules = rules, dot_args)
+    args <- c(list(table, rules = rules), dot_args)
     interpretation <- do.call(effectsize::interpret, args)$Interpretation
     rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))
   } else {

R/report_htest_fisher.R

@@ -15,7 +15,7 @@
   estimate <- names(table)[1]
   rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
 
-  args <- list(table, rules = rules, dot_args)
+  args <- c(list(table, rules = rules), dot_args)
   interpretation <- do.call(effectsize::interpret, args)$Interpretation
   rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))
 

R/report_htest_ttest.R

@@ -50,7 +50,7 @@
   estimate <- names(table)[1]
   rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
 
-  my_args <- list(table, rules = rules, dot_args)
+  my_args <- c(list(table, rules = rules), dot_args)
   interpretation <- do.call(effectsize::interpret, my_args)$Interpretation
   rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))