Review comments #1.

easwars · Apr 23, 2020 · b236292 · b236292
1 parent da320e5
commit b236292
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/balancer/rls/internal/client.go b/balancer/rls/internal/client.go
@@ -62,7 +62,7 @@ func newRLSClient(cc *grpc.ClientConn, dialTarget string, rpcTimeout time.Durati
 	}
 }
 
-type lookupCallback func(target []string, headerData string, err error)
+type lookupCallback func(targets []string, headerData string, err error)
 
 // lookup starts a RouteLookup RPC in a separate goroutine and returns the
 // results (and error, if any) in the provided callback.

diff --git a/balancer/rls/internal/client_test.go b/balancer/rls/internal/client_test.go
@@ -75,7 +75,7 @@ func TestLookupFailure(t *testing.T) {
 			return
 		}
 		if len(targets) != 0 || headerData != "" {
-			errCh <- fmt.Errorf("rlsClient.lookup() = (%v, %s), should be empty strings", targets, headerData)
+			errCh <- fmt.Errorf("rlsClient.lookup() = (%v, %s), want (nil, \"\")", targets, headerData)
 			return
 		}
 		errCh <- nil