Enable docker-enabled testing #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And test it using Github Actions. This should also make it easier to switch to other CI systems in the future
…into enable_docker_ci
|
Aha! Adding the test actions through the github UI to master and then pulling into this seems to have fixed it. I don't know why it wasn't triggering before. Permissions, maybe? At any rate, it is running now, and assuming it passes, I can:
|
|
Merged build finished. Test FAILed. |
|
Test FAILed. |
|
Merged build finished. Test PASSed. |
|
Test PASSed. |
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
Enable docker-enabled testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And test it using Github Actions.
This should also make it easier to switch to other CI systems in the future