Customise RCITI branch #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customise the intro steps: - Consent form - Random token login - Answer Kobo survey
shankari
requested changes
Aug 10, 2021
| $scope.disagree = function() { | ||
| $state.go('root.main.heatmap'); | ||
| }; | ||
|
|
||
| $scope.agree = function() { | ||
| StartPrefs.markConsented().then(function(response) { | ||
| $scope.randomToken = $scope.generateRandomToken(8); |
There was a problem hiding this comment.
I would bump this up since it is autogenerated and you are not getting the user to fill it out.
There was a problem hiding this comment.
What is a good number to use here? I'm still deciding whether to use a list of pre-generated tokens or not. One of the benefits is so that I can link my screening questionnaire responses to the trip database.
There was a problem hiding this comment.
If this is not a huge security concern.. Let's leave it like this for now.
shankari
approved these changes
Aug 10, 2021
|
@shankari Deploy in 10 mins? :) |
|
just pushed (had to create new channel etc), but should be live in ~ 10 mins at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
mastertorciti1has proven to be a bad idea. So we are slowly bringingrciti1tomasterinstead!a.siripanich at unsw (dot) edu.auby default.