-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the UI devapp server to use the standard build scripts #18
Change the UI devapp server to use the standard build scripts #18
Conversation
I originally wanted to put all the dependencies into the image instead of waiting until the container was set up. But different branches could have different dependencies and may not want to upgrade/downgrade. And putting this into the container allows us to use the standard build scripts and not have this bitrot. This file had ENV NODE_VERSION 9.4.0 RUN npm install -g npm@6.0.0 We are currently at export NODE_VERSION=14.7.0 export NPM_VERSION=6.14.8 using the standard scripts, which are regularly tested via CI, allows us to ensure that this dockerfile stays relevant across the many configurations that we currently support. This fixes e-mission/e-mission-docs#657
Tested using the following settings in the docker-compose
Note that I had to
|
Would this work if I run the emulator but edit code on a code editor that is not Android Studio? Would be good if you can explain how you run live reload. |
Ok, so the auto reload works fine on the master branch.. Let me try again on rciti1. |
You probably saw this, but you can edit the files with any editor and it will work. For the example above, I edited the files using vim. The large screen on the right is chrome, which is connected to the app and being used for debugging. |
Without this change, we get the following error while running in a docker container ``` Updating bower bower ESUDO Cannot be run with sudo Additional error details: Since bower is a user command, there is no need to execute it with superuser permissions. If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs. You can however run a command with sudo using "--allow-root" option ``` Since the default user in the container is `root`, this is actually an expected use case for us. I tried to avoid this by calling `bower update --allow-root` in the docker setup script e-mission/e-mission-docker#18 But that ran into multiple inconsistencies ( e-mission/e-mission-docs#657 (comment) e-mission/e-mission-docs#657 (comment) ) In order to avoid more bitrotted containers, just changing the code in the setup script so it works in the container as well This fixes e-mission/e-mission-docs#657
Without this change, we get the following error while running in a docker container ``` Updating bower bower ESUDO Cannot be run with sudo Additional error details: Since bower is a user command, there is no need to execute it with superuser permissions. If you're having permission errors when using bower without sudo, please spend a few minutes learning more about how your system should work and make any necessary repairs. You can however run a command with sudo using "--allow-root" option ``` Since the default user in the container is `root`, this is actually an expected use case for us. I tried to avoid this by calling `bower update --allow-root` in the docker setup script e-mission/e-mission-docker#18 But that ran into multiple inconsistencies ( e-mission/e-mission-docs#657 (comment) e-mission/e-mission-docs#657 (comment) ) In order to avoid more bitrotted containers, just changing the code in the setup script so it works in the container as well This fixes e-mission/e-mission-docs#657
I originally wanted to put all the dependencies into the image instead of
waiting until the container was set up. But different branches could have
different dependencies and may not want to upgrade/downgrade. And putting this
into the container allows us to use the standard build scripts and not have
this bitrot.
This file had
ENV NODE_VERSION 9.4.0
RUN npm install -g npm@6.0.0
We are currently at
export NODE_VERSION=14.7.0
export NPM_VERSION=6.14.8
using the standard scripts, which are regularly tested via CI, allows us to
ensure that this dockerfile stays relevant across the many configurations that
we currently support.
This fixes e-mission/e-mission-docs#657