Install emission no image #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- One which has the server code in the image - One which has the server code in the container Refactor the support scripts to split out clone and start. Then invoke clone in the image for the first one, and in the CMD for the second Unify the rest of the code This simplifies the dockerfiles tremendously, clarifies what they do, and avoids duplicated code Testing done: - Ran both kinds of docker containers and confirmed that I could see index.html
We want to have the flexibility to deploy from other branches so we use the dev image and call `/clone.sh` from the startup script. The two startup scripts are different since one of them starts the webapp and the other starts the cronjobs for the analysis layer.
Since we have now unified the server checkout location at /usr/src/app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.