Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a wrapper class for the activities as well #80

Closed
shankari opened this issue Feb 10, 2016 · 3 comments
Closed

Use a wrapper class for the activities as well #80

shankari opened this issue Feb 10, 2016 · 3 comments

Comments

@shankari
Copy link
Contributor

We already do this on iOS. On android, we are using gson directly, but the format is internal and is subject to change, and in fact did change when we bumped google play services versions.

it went from agb and agc to what looks like zzaEg and zzaEh, and of course, promptly broke all our formatting.

{u'zzaEg': 3, u'zzaEh': 92, u'mVersionCode': 1}, u'metadata': {u'write_ts': 1455096242, u'time_zone': u'America/Los_Angeles', u'platform': u'android', u'key': u'background/motion_activity', u'read_ts': 0, u'type': u'sensor-data'}}

We will work around this on the server now, but we really need to have a wrapper on the client that uses the public APIs. That will also make it easier to have a visualization of unpushed data on android.
shankari added a commit to shankari/e-mission-server that referenced this issue Feb 24, 2016
@shankari
Handle the weird field names from the new version of the API
cfeca08 
As part of the switch to cordova, we moved to a newer version of the google
play API. Unfortunately, this meant that the weird field names for the
confidence and type changed to a different set of weird field names. We should
really use a standard wrapper class for this on android as well to avoid such
silent breakages in the future.

e-mission/e-mission-data-collection#80
@shankari shankari mentioned this issue Jun 28, 2016
Merged
@shankari shankari reopened this Feb 27, 2017
@shankari
Copy link
Contributor Author

This was only referenced as a potential future cleanup, not actually fixed!

@shankari
Copy link
Contributor Author

shankari commented Jul 4, 2017

This was only referenced as a potential future cleanup, not actually fixed!

@shankari shankari reopened this Jul 4, 2017
@shankari shankari mentioned this issue Jul 4, 2017
Merged
@shankari
Copy link
Contributor Author

shankari commented Jul 4, 2017

This was only referenced as a potential future cleanup, not actually fixed!

@shankari shankari reopened this Jul 4, 2017
@shankari shankari mentioned this issue Nov 4, 2019
Open
@shankari shankari mentioned this issue Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shankari