Remove extraneous dependencies to slim down the app #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we don't use it and it causes confusion about which google play service we use
It looks like the separated files for 8.1.0 are not available. I do have 8.3.0 in my local SDK install, so let's switch to that instead. To answer the question from shankari/e-mission-data-collection@242cd2d Contrary to the documentation, https://developers.google.com/android/guides/setup#add_google_play_services_to_your_project the local SDK install has separated files only from 8.3.0 ``` bash-3.2$ ls /Users/shankari/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services/ 3.1.36/ 4.4.52/ 7.8.0/ 3.1.59/ 5.0.89/ 8.1.0/ 3.2.25/ 6.1.11/ 8.3.0/ 3.2.65/ 6.1.71/ maven-metadata.xml 4.0.30/ 6.5.87/ maven-metadata.xml.md5 4.1.32/ 7.0.0/ maven-metadata.xml.sha1 4.2.42/ 7.3.0/ 4.3.23/ 7.5.0/ ``` ``` bash-3.2$ ls /Users/shankari/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-auth/ 8.3.0 maven-metadata.xml.md5 maven-metadata.xml maven-metadata.xml.sha1 ```
shankari
added a commit
to shankari/e-mission-phone
that referenced
this pull request
Jun 24, 2016
But use the "lite" version so that we don't bloat up the apk again. With this change, and the changes to only include the parts of the google play API that we actually use, e-mission/cordova-jwt-auth#6 e-mission/e-mission-data-collection#116 we're using the most recent version of the crosswalk apk, while dropping 10MB off the size. new crosswalk, all google play: won't compile, dex too large old crosswalk, all google play: 33MB new crosswalk, selected google play: 22MB no crosswalk, selected google play: 23MB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.