Skip to content

Commit

Permalink
Do not upgrade hystrix dependency
Browse files Browse the repository at this point in the history
metrics are better with Netflix/Hystrix#1568 introduced in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018. <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
  • Loading branch information
shakuzen authored and pirgeo committed Jan 5, 2024
1 parent a7f93db commit 5497219
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ updates:
target-branch: "1.9.x"
milestone: 136
ignore:
# metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced
# in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018.
# <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
- dependency-name: "com.netflix.hystrix:hystrix-core"
# only upgrade patch versions
- dependency-name: "*"
update-types:
Expand All @@ -25,6 +29,10 @@ updates:
target-branch: "1.10.x"
milestone: 159
ignore:
# metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced
# in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018.
# <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
- dependency-name: "com.netflix.hystrix:hystrix-core"
# only upgrade patch versions
- dependency-name: "*"
update-types:
Expand All @@ -38,6 +46,10 @@ updates:
target-branch: "1.11.x"
milestone: 206
ignore:
# metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced
# in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018.
# <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
- dependency-name: "com.netflix.hystrix:hystrix-core"
# only upgrade patch versions
- dependency-name: "*"
update-types:
Expand All @@ -51,6 +63,10 @@ updates:
target-branch: "1.12.x"
milestone: 211
ignore:
# metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced
# in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018.
# <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
- dependency-name: "com.netflix.hystrix:hystrix-core"
# only upgrade patch versions
- dependency-name: "*"
update-types:
Expand All @@ -64,6 +80,10 @@ updates:
target-branch: "main"
milestone: 185
ignore:
# metrics are better with https://github.com/Netflix/Hystrix/pull/1568 introduced
# in hystrix 1.5.12, but Netflix re-released 1.5.11 as 1.5.18 late in 2018.
# <=1.5.11 or 1.5.18 doesn't break with Micrometer, but open metrics won't be correct necessarily.
- dependency-name: "com.netflix.hystrix:hystrix-core"
# upgrade minor and patch versions on main
- dependency-name: "*"
update-types:
Expand Down

0 comments on commit 5497219

Please sign in to comment.