Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support WeaveVM #1287

Merged
merged 4 commits into from
Mar 5, 2025
Merged

feat: support WeaveVM #1287

merged 4 commits into from
Mar 5, 2025

Conversation

anhductn2001
Copy link
Contributor

Close #1233

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@anhductn2001 anhductn2001 requested a review from a team as a code owner February 24, 2025 04:52
WithDefaultText(
"press 'y' when the wallet are funded",
).Show()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to have retry with balance check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do u have any idea for it? Im feeling a bit stuck

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something similar that we already have for balance checks:

https://github.com/dymensionxyz/roller/blob/main/cmd/eibc/init/init.go#L161-L189

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean how to query balance of weavevm?

@artemijspavlovs artemijspavlovs merged commit d39840a into main Mar 5, 2025
1 of 2 checks passed
@artemijspavlovs artemijspavlovs deleted the ducnt/weavevm branch March 5, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate WeaveVM DA to roller
2 participants