Fix for issue 191 #196
Closed
Fix for issue 191 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concatenate() should handle scalars
arcondello
reviewed
Jan 8, 2025
Comment on lines
+55
to
57
| "stack", | ||
| "sqrt", | ||
| "where", |
| @@ -516,6 +532,40 @@ def multiply(x1: ArraySymbol, x2: ArraySymbol, *xi: ArraySymbol, | |||
| raise RuntimeError("implementated by the op() decorator") | |||
|
|
|||
|
|
|||
| def stack(xi: collections.abc.Iterable): | |||
There was a problem hiding this comment.
I think this can apply for any number of dimensions, not just 0d. If we want to simplify, we could implement vstack instead, so it's always concatenating along the 1st axis. But I am guessing the stack isn't so bad.
Also -> ArraySymbol for the output typing.
There was a problem hiding this comment.
Ah good points, will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
concatenate() should handle scalars