Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve problem access waiting #105

Conversation

randomir
Copy link
Member

@randomir randomir commented Mar 29, 2021

Here we:

  • fix In Windows OS, terminal hangs if I try to show a sampleset a second time #104 by disabling caching of problem access callback response, so that each problem load notifies the server, even for repeated loads of agent-cached problems;
  • introduce timeout parameter in dwave.inspector.show() that works in conjunction with the block param to determine max wait time of show() for problem access.

@randomir randomir requested a review from JoelPasvolsky March 29, 2021 23:42
@JoelPasvolsky
Copy link
Contributor

This solves problem #104 on unix but WIN still hangs (with or without explicit timeout:

In [5]: sampleset = EmbeddingComposite(DWaveSampler()).sample(bqm, num_reads=100)

In [6]: dwave.inspector.show(sampleset, timeout=1)
Out[6]: 'http://127.0.0.1:18000/?problemId=ccae2bd8-3c0d-4271-b63c-8afce436602d'

In [7]: dwave.inspector.show(sampleset, timeout=1)

@randomir
Copy link
Member Author

It hangs even with timeout set?! Hm..

@randomir randomir force-pushed the bugfix/show-blocking-second-time/issue-104 branch 2 times, most recently from 3ff6ad2 to 26140f5 Compare June 9, 2021 14:42
@randomir
Copy link
Member Author

randomir commented Jun 9, 2021

For posterity, @JoelPasvolsky says this PR fixes #104, but he's still seeing #48.

@randomir randomir force-pushed the bugfix/show-blocking-second-time/issue-104 branch from f2a80fb to 50af42c Compare June 9, 2021 21:28
@randomir randomir merged commit 802331c into dwavesystems:master Jun 9, 2021
@randomir randomir deleted the bugfix/show-blocking-second-time/issue-104 branch June 9, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Windows OS, terminal hangs if I try to show a sampleset a second time
2 participants