Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large neighborhood local search lattice components introduced #252

Merged
merged 12 commits into from
Oct 4, 2021

Conversation

jackraymond
Copy link
Contributor

@jackraymond jackraymond commented Sep 27, 2021

The Class SublatticeDecomposer() and the function make_origin_embeddings() are introduced for creation of lattice workflows. make_origin_embeddings() has several helper functions. This code is introduced in decomposers.py
Two unit tests are currently present for SublatticeDecomposer, tests pass locally. More tests will be added shortly.
A reference example has been added to docs/reference/decomposers.rst , visual inspection of compiled docstrings and examples looks fine.
This pull request relates to a QUBITS2021 presentation scheduled for October 6th 2021.

…umentation. Made problem_dims an optional arugment for SublatticeSolver. Renamed exclude_dimensions to exclude_dims (for compatibility with problem_dims). Implemented pull request review suggestions by JoelP.
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #252 (fd86b78) into master (e43522a) will increase coverage by 0.01%.
The diff coverage is 87.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   89.52%   89.54%   +0.01%     
==========================================
  Files          17       17              
  Lines        1872     2009     +137     
==========================================
+ Hits         1676     1799     +123     
- Misses        196      210      +14     
Impacted Files Coverage Δ
hybrid/samplers.py 91.62% <0.00%> (+0.46%) ⬆️
hybrid/decomposers.py 88.68% <89.13%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43522a...fd86b78. Read the comment docs.

Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Jack.

The only thing missing are some tests of the make_origin_embeddings function.

@randomir
Copy link
Member

randomir commented Oct 4, 2021

🎉

@randomir randomir merged commit c3b2807 into dwavesystems:master Oct 4, 2021
randomir added a commit that referenced this pull request Oct 4, 2021
New Features
---
- `make_origin_embeddings` problem decomposing utility that creates
  optimal embeddings for a lattice. Embeddings are compatible with
  the topology and shape of D-Wave QPU samplers
  (#252).
- `SublatticeDecomposer` that produces lattice-structured subproblems
  (#252).

Fixes
---
- `SteepestDescentProblemSampler` now actually uses
  `greedy.SteepestDescentSolver`
  (#250).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants