Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uplink: impl TryFrom<String> for ContractId #421

Merged
merged 1 commit into from
Feb 20, 2025
Merged

uplink: impl TryFrom<String> for ContractId #421

merged 1 commit into from
Feb 20, 2025

Conversation

Neotamandua
Copy link
Member

  • Add tests
  • Add comments
  • Update CHANGELOG

@Neotamandua Neotamandua linked an issue Feb 14, 2025 that may be closed by this pull request
Ability to convert a String to a ContractId #420
Closed
@Neotamandua Neotamandua force-pushed the neotamandua/from_string branch from 7090eed to ac9bee3 Compare February 14, 2025 12:45
@Neotamandua Neotamandua force-pushed the neotamandua/from_string branch 2 times, most recently from 333c909 to 11f3147 Compare February 14, 2025 12:57
@Neotamandua
uplink: impl TryFrom<String> for ContractId
79e9d51 
- Add tests
- Add comments
- Update CHANGELOG
- Make hex not optional
@Neotamandua Neotamandua force-pushed the neotamandua/from_string branch from 11f3147 to 79e9d51 Compare February 14, 2025 13:19
miloszm
miloszm approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neotamandua Neotamandua merged commit c7015f5 into main Feb 20, 2025
6 checks passed
@Neotamandua Neotamandua deleted the neotamandua/from_string branch February 20, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miloszm miloszm miloszm approved these changes

@HDauven HDauven Awaiting requested review from HDauven

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to convert a String to a ContractId
2 participants
@Neotamandua @miloszm