Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement const fns when applicable #93

Closed
vlopes11 opened this issue Apr 6, 2022 · 0 comments · Fixed by #94
Closed

Implement const fns when applicable #93

vlopes11 opened this issue Apr 6, 2022 · 0 comments · Fixed by #94

Comments

@vlopes11
Copy link

vlopes11 commented Apr 6, 2022

Describe what you want implemented
Implement const fns for JubJubAffine and JubJubExtended

Describe "Why" this is needed
Points conversion could be done transparently with const fns instead of using magic raw u64 internals. For that to happen, we need to maximize the domain of const fns in the library

Describe alternatives you've considered
Using magic u64 everywhere is very cryptic
vlopes11 added a commit that referenced this issue Apr 6, 2022
@vlopes11
Add const directive to JubJubExtended
2e3e5ca 
Points conversion could be done transparently with `const` functions
instead of using magic `u64` internals.

For that to happen, we need to maximize the domain of `const` functions
in the library.

Resolves #93
@vlopes11 vlopes11 mentioned this issue Apr 6, 2022
Merged
vlopes11 added a commit that referenced this issue Apr 6, 2022
@vlopes11
Add const directive to JubJubExtended
cfe5eab 
Points conversion could be done transparently with `const` functions
instead of using magic `u64` internals.

For that to happen, we need to maximize the domain of `const` functions
in the library.

Resolves #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add const directive to JubJubExtended dusk-network/jubjub
1 participant
@vlopes11