Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge our implementation with upstream implementation #115

Closed
moCello opened this issue Jun 1, 2023 · 0 comments · Fixed by #116
Closed

Merge our implementation with upstream implementation #115

moCello opened this issue Jun 1, 2023 · 0 comments · Fixed by #116

Comments

@moCello
Copy link
Member

moCello commented Jun 1, 2023

Summary

Our implementation has diverted significantly from the zkcrypto upstream original. In order to get the upstream improvements it is good to have them merged.
ureeves pushed a commit that referenced this issue Jun 5, 2023
Take upstream impls and segregate modifications
2d910ff 
The upstream implementations are taken verbatim, and our own
modification are added in a more segregated manner, for ease of
identification.

Resolves: #115, #110
@ureeves ureeves mentioned this issue Jun 5, 2023
Merged
ureeves pushed a commit that referenced this issue Jun 5, 2023
Take upstream impls and segregate modifications
93900a2 
The upstream implementations are taken verbatim, and our own
modification are added in a more segregated manner, for ease of
identification.

Resolves: #115, #110
ureeves pushed a commit that referenced this issue Jun 7, 2023
Take upstream impls and segregate modifications
885e1e9 
The upstream implementations are taken verbatim, and our own
modification are added in a more segregated manner, for ease of
identification.

Resolves: #115, #110
ureeves pushed a commit that referenced this issue Jun 7, 2023
Take upstream impls and segregate modifications
2f698f0 
The upstream implementations are taken verbatim, and our own
modification are added in a more segregated manner, for ease of
identification.

Resolves: #115, #110
@ureeves ureeves mentioned this issue Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take upstream impls and segregate modifications dusk-network/jubjub
1 participant
@moCello