Implement remote-staking output validation in coinbase transactions #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyantyn
reviewed
Feb 26, 2019
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
Signed-off-by: Azat Nizametdinov <azat@thirdhash.com>
Nizametdinov
force-pushed
the
remote-staking-validation
branch
from
bb88214 to
deb38f9
Compare
scravy
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
utACK deb38f9
This looks good to me, it faithfully implements the rule (as per UIP15):
If a coinbase transaction contains an input with a remote-staking scriptPubKey then at least the same amount MUST be sent back to the same scriptPubKey.
I am wondering though about one thing (which does not prevent this form merging, just, if I did not overlook something, something which might needed to be added?), see comment inline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following consensus rule: