Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable testing on macos-latest #361

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Re-enable testing on macos-latest #361

wants to merge 20 commits into from

Conversation

ejm714
Copy link
Collaborator

@ejm714 ejm714 commented Mar 19, 2025

The disabling in #349 was a holdover from development in a private repo

Closes #365

@ejm714 ejm714 requested a review from pjbull March 19, 2025 06:19
Copy link
Contributor

github-actions bot commented Mar 19, 2025

@pjbull
Copy link
Member

pjbull commented Mar 19, 2025

Looks like the tests action didn't run at all because maybe there is no relevant change. We should add the workflow files to ones that trigger test runs.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.0%. Comparing base (6079acb) to head (468e87b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #361     +/-   ##
========================================
+ Coverage    82.8%   84.0%   +1.1%     
========================================
  Files          37      37             
  Lines        3191    3191             
========================================
+ Hits         2645    2682     +37     
+ Misses        546     509     -37     
Files with missing lines Coverage Δ
zamba/images/data.py 97.8% <100.0%> (+12.0%) ⬆️
zamba/images/manager.py 82.4% <100.0%> (+0.6%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ejm714
Copy link
Collaborator Author

ejm714 commented Mar 19, 2025

Good call @pjbull. Looks like there are a couple mac specific errors

  • FAILED tests/test_config.py::test_predict_dry_run_and_save - FileNotFoundError: [Errno 2] No such file or directory: '/Users/runner/work/zamba/zamba/.zamba-weights/time_distributed_1d483fc723.ckpt.40BF9da1' -> '/Users/runner/work/zamba/zamba/.zamba-weights/time_distributed_1d483fc723.ckpt'
  • FAILED tests/test_cli.py::test_train_specific_options - AssertionError: assert 1 == 0 + where 1 = <Result FileNotFoundError(2, 'No such file or directory')>.exit_code
  • FAILED tests/test_cli.py::test_actual_prediction_on_images - AssertionError: assert 1 == 0 + where 1 = <Result RuntimeError('MPS backend out of memory (MPS allocated: 8.00 MB, other allocations: 16.00 KB, max allowed: 7.93 GB). Tried to allocate 256 bytes on shared pool. Use PYTORCH_MPS_HIGH_WATERMARK_RATIO=0.0 to disable upper limit for memory allocations (may cause system failure).')>.exit_code
  • FAILED tests/test_images.py::test_train_integration - RuntimeError: MPS backend out of memory (MPS allocated: 8.00 MB, other allocations: 0 bytes, max allowed: 7.93 GB). Tried to allocate 256 bytes on shared pool. Use PYTORCH_MPS_HIGH_WATERMARK_RATIO=0.0 to disable upper limit for memory allocations (may cause system failure).

@ejm714
Copy link
Collaborator Author

ejm714 commented Mar 19, 2025

Nested-virtualization and Metal Performance Shaders (MPS) are not supported due to the limitation of Apple's Virtualization Framework.

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners

Looks like we need to force CPU for the image tests since it's trying to use MPS and then failing

@ejm714 ejm714 marked this pull request as draft March 19, 2025 22:12
@ejm714 ejm714 marked this pull request as ready for review March 21, 2025 05:22
@ejm714
Copy link
Collaborator Author

ejm714 commented Mar 21, 2025

Tests are finally passing 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable OSX build testing on public repo
2 participants