More accurate error messages when failing to set properties

[mskfox]

In reference to #249

[mskfox]

The new message (following the example from issue #249) looks like this, thus no longer providing false information to the developer.

[mskfox]

Instead of [Fusion] 'UIAspectRatioConstraint.AspectRatio' expected a 'number' type, but got a 'number' type. (ID: invalidPropertyType)

[dphfox]

This seems overly verbose; I would suggest trimming down the message significantly. The error message duplicates information about what property was set on what instance, so we don't need to include it ourselves.

I would suggest: Error setting property: ERROR_MESSAGE

Same for the ID; it'd be better off as propertySetError to save space. It still communicates the same meaning.

Other than that, this change seems to be fine.

[mskfox]

This looks good, we can also combine the two error messages if needed. Initially, I didn't do it because Fusion might prefer having them separate for clearer documentation on different error types.

local function setProperty(instance: Instance, property: string, value: any)
	local success, err = xpcall(setProperty_unsafe, parseError, instance, property, value)

	if not success then
		if not pcall(testPropertyAssignable, instance, property) then
			-- ...
		else
			-- invalidPropertyType no longer used
			logError("propertySetError", err)
		end
	end
end

What's your take on this?

[dphfox]

I think it's fine to keep the invalidPropertyType error.

[mskfox]

Alright, all the issues should be patched.