Replace ajv pack with standalone #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! I've not used ajv and JSON schemas for a few years. Maybe someone of the ajv or ajv-pack collaborators may take a look. Or I can just merge it and publish new version, so anyone can test it. It's new major release, so nothing should change for existing projects according to the semver. |
|
@downace i have just the project to try it on |
|
Done, the 0.2.0 version published at npmjs.com. |
awesome, thank you, I'll follow up with another PR if there are any issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following on from #6 , I have updated
ajv-json-loaderto use the latest ajv and replaced ajv-pack with ajv standalone.I have also updated the code to typescript. I needed to do this as I don't know ajv that well and the types kept me right.
All tests are passing but I had to update the snapshot code tests as the latest ajv code generates different code which is to be expected.
I would appreciate it if someone could cast a qualified eye over the new snapshots.
I do not know ajv very well at all so I would appreciate a more qualified look.