Add ability to clear config #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sampacos
commented
Feb 16, 2023
sampacos
commented
- rework configuration to remove possibility of stack overflow exception.
- generally clean up configuration. add ability to clear all config values set since runtime started.
- add more exceptions to places we're looking for elements.
…n. generally clean up configuration. add ability to clear all config values set since runtime started. add more exceptions to places we're looking for elements.
added 6 commits
February 16, 2023 18:00
…s timeout back to original values
…found. add new element method to support this. update maven yml to upload whole reports folder on failure to preserve screenshots in extentreport. update chrome option for headless for change starting in chromedriver v110. add debug logs for download directory operations.
…leanup unit tests to no longer wipe configured timeout
dougnoel
previously approved these changes
Feb 17, 2023
pturchinetz
previously approved these changes
Feb 17, 2023
…d returns the changed chromeoptions
|
Kudos, SonarCloud Quality Gate passed! |
pturchinetz
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.