Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i_am_redirected_to_the_page should validate page load #78

Closed
dougnoel opened this issue Mar 10, 2020 · 0 comments · Fixed by #136
Closed

i_am_redirected_to_the_page should validate page load #78

dougnoel opened this issue Mar 10, 2020 · 0 comments · Fixed by #136
Milestone
2.0.0

Comments

@dougnoel
Copy link
Owner

This is a verification step and it should validate that the DOM has loaded. This should succeed even if we actually are still on the same page (for example when using a popup).
@dougnoel dougnoel added this to the 1.0.4 milestone Mar 10, 2020
dougnoel added a commit that referenced this issue May 12, 2020
@dougnoel
Fixed #60 where waits were necessary after page loads and some drop d…
7e58db2 
…own clicks. Fixed #78 and we are now waiting for page load on redirects. Fixed #135 a bug where waits were always waiting at least a second. Added FAQ to readme for using waits. Removed unused code from PageElement when I realized items not being found was not a problem with the method finding them, but an error with clicking on things.
@dougnoel dougnoel mentioned this issue May 12, 2020
Merged
@dougnoel dougnoel modified the milestones: 1.0.4, 2.0.0 Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Fixed #60 where waits were necessary after page loads and some drop d… dougnoel/sentinel
1 participant
@dougnoel