Skip to content

Make Traprange an internal library or remove it #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dougnoel opened this issue Feb 11, 2020 · 1 comment · Fixed by #37
Closed

Make Traprange an internal library or remove it #28

dougnoel opened this issue Feb 11, 2020 · 1 comment · Fixed by #37
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@dougnoel
Copy link
Owner

Traprange is not available on Maven Central. We either need to remove it or make it part of the project.

Make Traprange an internal library under com.giabac.traprange.
Remove Traprange from the pom.xml

@dougnoel dougnoel added this to the 1.0.3 milestone Feb 11, 2020
@dougnoel
Copy link
Owner Author

For now, create a traprange branch that includes it, then remove it from sentinel. It can be added back in later if needed. Otherwise the branch can be removed. All traprange does is allow you to view PDFs as tables when there are tables in them. It's very niche and has caused a lot of problems for a small feature.

@dougnoel dougnoel added enhancement New feature or request documentation Improvements or additions to documentation labels Feb 11, 2020
@dougnoel dougnoel mentioned this issue Feb 13, 2020
@dougnoel dougnoel linked a pull request Feb 13, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant