Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IsPackable to false for the k8s project #2005

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

MihaZupan
Copy link
Member

@MihaZupan MihaZupan commented Jan 18, 2023

Brings back #941
This slipped through in #1642 when we rearranged all the k8s project files.

Contributes to #1995

I'll backport this to main as well.

@MihaZupan MihaZupan added this to the YARP 2.0.0-RC1 milestone Jan 18, 2023
@MihaZupan MihaZupan self-assigned this Jan 18, 2023
@MihaZupan MihaZupan requested a review from Tratcher as a code owner January 18, 2023 19:01
@Tratcher
Copy link
Member

Rather than backport, merge this branch into main.

Do you need this to avoid shipping the packages? Can the release step just exclude them instead?

@MihaZupan
Copy link
Member Author

Do you need this to avoid shipping the packages?

Yes

Can the release step just exclude them instead?

I don't see anything in Azdo for it

@MihaZupan MihaZupan merged commit 50919f1 into release/2.0.0-rc1 Jan 18, 2023
@MihaZupan MihaZupan deleted the MihaZupan-patch-1 branch January 18, 2023 19:18
@MihaZupan
Copy link
Member Author

Looks good now
image

MihaZupan added a commit that referenced this pull request Jan 19, 2023
Set IsPackable to false for the k8s project (#2005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants