Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable template localization on dotnet CLI #5996

Merged

Conversation

rokonec
Copy link
Member

@rokonec rokonec commented Jan 26, 2022

Fixes #
related to dotnet/templating#4308

Description

Template engine (dotnet new) added support for template localizations in .NET 6.0. This new system replaces the old way of localizing templates that only worked on Visual Studio and works on both .NET CLI as well as VS.

This PR introduces changes to switch to the new template localization system.

Summary of the changes

  • Adds <UsingToolTemplateLocalizer>true</> to projects containing templates.
  • Generates localization files to be translated by loc team

What to expect after merging

Every time there is a change to one of the templates:

  • The dev making the change should build (at the very least) the modified template project. This will update the loc files on the local working copy,
  • Push the loc files together with the template modifications. Review & merge.
  • OneLocBuild integration will automatically pick up the changes and will send them for translation.
  • You will receive a PR containing the translated template loc files when they are ready. Review & merge.

Customer Impact

Regression

Testing

Risk

@rokonec rokonec requested a review from a team as a code owner January 26, 2022 13:25
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jan 26, 2022
@ghost ghost requested review from fabiant3, ryalanms and SamBent January 26, 2022 13:25
@singhashish-wpf singhashish-wpf merged commit c1b0b18 into dotnet:main Jan 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants