Updating Compression Native dll Name (dotnet#505) #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #505
Description
WPF makes calls into this private DLL:
wpf/src/Microsoft.DotNet.Wpf/src/Common/src/Interop/Windows/Interop.Libraries.cs
Line 35 in 89d172d
wpf/src/Microsoft.DotNet.Wpf/src/Common/src/Interop/Windows/zlib/zlib.cs
Line 43 in 89d172d
https://github.com/dotnet/wpf/blob/89d172db0b7a192de720c6cfba5e28a1e7d46123/src/Microsoft.DotNet.Wpf/src/WindowsBase/MS/Internal/IO/Packaging/Compoundfile/CompoundFileDeflateTransform.cs
clrcompression.dll has been renamed to System.IO.Compression.Native. After renaming clrcompression.dll, createStream API is not working due to its dependency on clrcompression, So, It needs to be fixed to use the new name for 6.0.
Customer Impact
Regression
Testing
Risk