Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 217: Build ID 1296794 #5081

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

dotnet-bot
Copy link
Contributor

No description provided.

@dotnet-bot dotnet-bot requested a review from a team as a code owner August 16, 2021 21:31
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 16, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent August 16, 2021 21:31
@ryalanms
Copy link
Member

There aren't any actual changes to the strings contained in this update.

/cc @jonfortescue

@jonfortescue
Copy link
Contributor

jonfortescue commented Aug 16, 2021

@ryalanms looks like these are BOM changes being made. I'd say just merge this one and it shouldn't happen again.

(this is a known issue with OneLocBuild but since the workaround above works they have not prioritized working on it)

@ryalanms ryalanms merged commit c9b356f into main Aug 16, 2021
@ryalanms
Copy link
Member

@cristianosuzuki77: What are the steps required to get these strings translated? The OneLocBuild task isn't resolving the strings.

@vishalmsft vishalmsft deleted the locfiles/58b80cac-bad7-45c8-a7c2-e82ca4761649 branch February 10, 2022 06:04
@ghost ghost locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants