-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/winforms #4823
[main] Update dependencies from dotnet/winforms #4823
Conversation
…10708.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.1 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
…10708.6 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.6 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
…10708.10 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.10 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
The build is failing with hundreds of errors in DirectWriteForwarder.vcxproj like:
|
…10708.11 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21358.11 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
…10709.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21359.1 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
@ryalanms , Can you check on this or include right people to take a look and unblock the flow? |
@SamBent/ @ryalanms , can you help what is wrong here and unblock? Winforms CTI team is blocked on validating latest bits. |
/cc @dotnet/dnr-codeflow
|
…10712.1 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.1 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
…10712.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.2 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21358.2 (parent: Microsoft.Private.Winforms
pinging direct members to get quicker response. @danmoseley, @jeffschwMSFT and @marek-safar |
this is @tannergooding |
Is this failure in C++/CLI? |
@danmoseley / @jeffschwMSFT -- Does either of you know a contact on the CPP / CLI team that we can reach out to to explore options for working around this? |
@davidwrighton will know. |
@ryalanms / @fabiant3 -- This is caused by the introduction of Generic Math in #54650, which uses the new static abstract interface members language feature. From what we can tell, the C++/CLI does not support usage of the language feature (or other new-ish language features) in the primitive types affected. We are going to explore two mitigation paths:
Obviously, the second option will take time. Disabling Generic Math would still take a few days to flow through. In the meantime, is it reasonable to pin the runtime version used by winforms and/or WPF to the previous version? |
dotnet/runtime#55540 is the runtime side draft PR to disable the generic math feature if we determine that to be necessary until C++/CLI can be updated to accommodate the feature. |
@tgani-msft (MSFT alias tgani) is the C++/CLI contact for .NET Core (or at least was the last time I worked on C++/CLI-related work. |
Thanks, @jeffhandley. Pinning to the previous version temporarily would be fine for WPF. (winforms and wpf share the same versions of the runtime.) @merriemcgaw @RussKie @dreddy-work: Can winforms temporarily use an older version of the runtime that does not contain the generic math change (e.g., 6.0.0-preview.7.21352.2)? |
I do not see any reason why it won't. We did not take any specific dependencies recently for this.. |
…10712.3 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.3 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21361.10 (parent: Microsoft.Private.Winforms
@dreddy-work please disable the in-flow into the winforms main from runtime using darc for now. |
Can you point me to instruction on where/how we do this? |
I'm on a personal machine. Ask in the @dnceng Teams channel or ping @mmitche for help. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Now we need to wait for the winforms downgrade to flow through... ⏳ |
…10712.4 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.4 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21361.10 (parent: Microsoft.Private.Winforms
…10712.5 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21362.5 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21352.2 (parent: Microsoft.Private.Winforms
I think a |
@hez2010 If I understood the problem correctly, the problem is not generic math per se. It's the static interface members which are required for generic math. Also, I think EnablePreviewFeatures only removes the code when using Trimming because the code is still in the ref assembly and I don't think the C++/CLI linker is aware of the feature switches/preview features. Either way, I think that for this to work, the support of static interface members would require modification to C++/CLI to either include the code correctly or to link it away. |
Actually I have no idea about whether it will work for ref assemblies or not... And of course C++/CLI should add support for consuming virtual static members IMO. |
@ryalanms please apply downgrades to 6.0.0-preview.7.21352.2 in this PR
|
D:\workspace_work\1\s\src\Microsoft.DotNet.Wpf\src\Themes\PresentationFramework.Aero2\PresentationFramework.Aero2.csproj : error NU1605: PresentationFramework.Aero2 -> Microsoft.Private.Winforms 6.0.0-preview.7.21362.5 -> Microsoft.NETCore.Platforms (>= 6.0.0-preview.7.21361.10) [D:\workspace_work\1\s\Microsoft.Dotnet.Wpf.sln] We need to take the same version of the runtme that the winforms package was built against. In this case, 6.0.0-preview.7.21361.10 (for Microsoft.Private.Winforms 6.0.0-preview.7.21362.5). |
@ryalanms , winforms did downgrade to 6.0.0-preview.7.21352.2 and dependency flow reached to this PR with commit . Can you clarify on why you see this binary is targeting higher version? |
@dreddy-work: This is the file that needs to be changed in the winforms repo: https://github.com/dotnet/winforms/blob/main/eng/Versions.props It is targeting 6.0.0-preview.7.21361.10, not 6.0.0-preview.7.21352.2. Now that there is more time, we should just wait for dotnet/runtime#55540. |
…10714.2 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-preview.7.21357.9 -> To Version 6.0.0-preview.7.21364.2 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-preview.7.21352.2 -> To Version 6.0.0-preview.7.21363.9 (parent: Microsoft.Private.Winforms
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/winforms