Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pattern matching in TaskExtensions #4424

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Use pattern matching in TaskExtensions #4424

merged 1 commit into from
Jan 3, 2022

Conversation

lindexi
Copy link
Member

@lindexi lindexi commented Apr 18, 2021 •
edited
Loading

Description

Use pattern matching in TaskExtensions.cs. It will be clearer.

Customer Impact

Regression

Testing

Just CI.

Risk

Low.

@lindexi lindexi requested a review from a team as a code owner April 18, 2021 03:58
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Apr 18, 2021
@ghost ghost requested review from fabiant3, ryalanms and SamBent April 18, 2021 03:58
anjali-wpf
anjali-wpf approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@anjali-wpf anjali-wpf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be some description for the PR requests, it should not be empty.

@anjali-wpf anjali-wpf self-assigned this Dec 12, 2021
@dipeshmsft dipeshmsft merged commit 7fa90f6 into dotnet:main Jan 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anjali-wpf anjali-wpf anjali-wpf approved these changes

@fabiant3 fabiant3 Awaiting requested review from fabiant3

@ryalanms ryalanms Awaiting requested review from ryalanms

@SamBent SamBent Awaiting requested review from SamBent

Assignees

@anjali-wpf anjali-wpf

Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindexi @anjali-wpf @dipeshmsft