Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-preview6] Update dependencies from dotnet/winforms #3082

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 2, 2020

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Microsoft.Win32.Registry: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.CodeDom: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Configuration.ConfigurationManager: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Diagnostics.EventLog: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.DirectoryServices: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Drawing.Common: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Reflection.MetadataLoadContext: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Security.AccessControl: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Security.Cryptography.Xml: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Security.Permissions: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Security.Principal.Windows: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Windows.Extensions: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • Microsoft.NETCore.Platforms: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.IO.Packaging: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • Microsoft.NETCore.ILDAsm: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • Microsoft.NETCore.ILAsm: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • System.Resources.Extensions: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)
  • Microsoft.NETCore.App.Internal: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms)

From https://github.com/dotnet/winforms

  • Subscription: 2fd2f8cf-0994-455c-2070-08d7f76cde51
  • Build: 20200606.1
  • Date Produced: 6/6/2020 10:29 AM
  • Commit: 81ba46e69bf930a9e963268ec13f5472f40eb06b
  • Branch: refs/heads/release/5.0-preview6
  • Updates:
    • Microsoft.Private.Winforms: from 5.0.0-preview.6.20280.1 to 5.0.0-preview.6.20306.1
    • Microsoft.Win32.Registry: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.CodeDom: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Configuration.ConfigurationManager: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Diagnostics.EventLog: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.DirectoryServices: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Drawing.Common: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Reflection.MetadataLoadContext: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Security.AccessControl: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Security.Cryptography.Xml: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Security.Permissions: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Security.Principal.Windows: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Windows.Extensions: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • Microsoft.NETCore.Platforms: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.IO.Packaging: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • Microsoft.NETCore.ILDAsm: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • Microsoft.NETCore.ILAsm: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • System.Resources.Extensions: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6
    • Microsoft.NETCore.App.Internal: from 5.0.0-preview.6.20279.7 to 5.0.0-preview.6.20305.6

…00602.7

Microsoft.Private.Winforms
 From Version 5.0.0-preview.6.20280.1 -> To Version 5.0.0-preview.6.20302.7

Dependency coherency updates

Microsoft.Win32.Registry,System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.AccessControl,System.Security.Cryptography.Xml,System.Security.Permissions,System.Security.Principal.Windows,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Internal
 From Version 5.0.0-preview.6.20279.7 -> To Version 5.0.0-preview.6.20302.4 (parent: Microsoft.Private.Winforms
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner June 2, 2020 21:34
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 2, 2020
@ghost ghost requested review from fabiant3, ryalanms and SamBent June 2, 2020 21:34
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 2, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

…00602.8

Microsoft.Private.Winforms
 From Version 5.0.0-preview.6.20280.1 -> To Version 5.0.0-preview.6.20302.8

Dependency coherency updates

Microsoft.Win32.Registry,System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.AccessControl,System.Security.Cryptography.Xml,System.Security.Permissions,System.Security.Principal.Windows,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Internal
 From Version 5.0.0-preview.6.20279.7 -> To Version 5.0.0-preview.6.20302.5 (parent: Microsoft.Private.Winforms
@lukas-lansky
Copy link
Contributor

lukas-lansky commented Jun 3, 2020

MS\Internal\WindowsRuntime\Windows\UI\ViewManagement\InputPane.cs(13,38): error CS0234: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'WindowsRuntime' does not exist in the namespace 'System.Runtime.InteropServices' (are you missing an assembly reference?)
MS\Internal\WindowsRuntime\Windows\UI\ViewManagement\InputPane.cs(199,28): error CS0246: (NETCORE_ENGINEERING_TELEMETRY=Build) The type or namespace name 'IActivationFactory' could not be found (are you missing a using directive or an assembly reference?)

Strange. Any idea what the problem might be here @fabiant3?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 3, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@ryalanms
Copy link
Member

ryalanms commented Jun 4, 2020

@rladuca identified the change (dotnet/runtime#36715) that caused the failure.

@ryalanms
Copy link
Member

ryalanms commented Jun 4, 2020

@jkoritzinsky: Could you take a look?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 4, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@jkoritzinsky
Copy link
Member

In dotnet/runtime#36715 we've removed support for the built-in WinRT types and being able to load WinRT types into the runtime directly. We now require users to use C#/WinRT or the new projection system to support WinRT types.

For your particular scenario, you should be able to directly P/Invoke to WindowsCreateString and RoGetActivationFactory to get a COM RCW for the activation factory that you can cast to IInputPaneInterop or IInputPane2 for your usages.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 4, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@rladuca
Copy link
Member

rladuca commented Jun 4, 2020

In dotnet/runtime#36715 we've removed support for the built-in WinRT types and being able to load WinRT types into the runtime directly. We now require users to use C#/WinRT or the new projection system to support WinRT types.

For your particular scenario, you should be able to directly P/Invoke to WindowsCreateString and RoGetActivationFactory to get a COM RCW for the activation factory that you can cast to IInputPaneInterop or IInputPane2 for your usages.

What about the following:
https://github.com/microsoft/CsWinRT/blob/f7c160fac69b946b531462722842cffaae4cf76d/cswinrt/strings/WinRT.cs#L160

That seems to be the equivalent of:

_winRtActivationFactory = WindowsRuntimeMarshal.GetActivationFactory(s_WinRTType);

Is that a reasonable assumption?

@jkoritzinsky
Copy link
Member

Yes, that is correct.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 4, 2020

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet-wpf CI, dotnet-wpf CI (Build Windows_NT Build_Release_x64), dotnet-wpf CI (Build Windows_NT Build_Debug_x64), dotnet-wpf CI (Build Windows_NT Build_Release_x86), dotnet-wpf CI (Build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

dotnet-maestro bot and others added 3 commits June 5, 2020 10:46
…00605.2

Microsoft.Private.Winforms
 From Version 5.0.0-preview.6.20280.1 -> To Version 5.0.0-preview.6.20305.2

Dependency coherency updates

Microsoft.Win32.Registry,System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.AccessControl,System.Security.Cryptography.Xml,System.Security.Permissions,System.Security.Principal.Windows,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Internal
 From Version 5.0.0-preview.6.20279.7 -> To Version 5.0.0-preview.6.20304.6 (parent: Microsoft.Private.Winforms
…00606.1

Microsoft.Private.Winforms
 From Version 5.0.0-preview.6.20280.1 -> To Version 5.0.0-preview.6.20306.1

Dependency coherency updates

Microsoft.Win32.Registry,System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.AccessControl,System.Security.Cryptography.Xml,System.Security.Permissions,System.Security.Principal.Windows,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Internal
 From Version 5.0.0-preview.6.20279.7 -> To Version 5.0.0-preview.6.20305.6 (parent: Microsoft.Private.Winforms
@dotnet-maestro dotnet-maestro bot merged commit 505af79 into release/5.0-preview6 Jun 6, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-release/5.0-preview6-c22156a1-97a6-431d-a1a1-edbf6805d7cb branch June 6, 2020 11:22
@ghost ghost locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants