Fix some threading issues when using a non-default sync context #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing test cases are unrelated. |
StephenBonikowsky
approved these changes
May 15, 2019
StephenBonikowsky
added a commit
to StephenBonikowsky/wcf
that referenced
this pull request
May 15, 2019
* After resolving a separate issue fixed by dotnet#3640 these tests are now failing for an existing issue explained in dotnet#2870.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a policy that if a non-default sync context is being used, to avoid potential deadlock (e.g. with a single threaded sync context such as used by winforms and WPF) or thread starvation problems, we forcefully asynchronously continue execution on the worker thread pool.
We had a few code paths where this didn't happen. This fixes those code paths.