Fix Soap12 for HTTP #3426
Merged
Fix Soap12 for HTTP #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signing-off but would like to understand more about the fix, was Soap12 never supposed to be supported in the NetTcp code path? |
StephenBonikowsky
approved these changes
Mar 4, 2019
|
When I used the same binding config for Soap12 on .NET Framework, I got the exact same exception as we were seeing in the test on .NET Core. I checked the code path and there's an unavoidable exception (no other conditions can prevent it) when using AddressingVersion.None with NetTcp. I did a quick look for any documentation about it and couldn't find it, but the code is very straightforward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2711
Remove test for NetTcp as not valid config for NetTcp, only HTTP