fixes dotnet/templating #3807 update subcommand #4045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidKarlas
approved these changes
Oct 22, 2021
| templatePackageManager, | ||
| templateInformationCoordinator); | ||
|
|
||
| return await templatePackageCoordinator.EnterUpdateFlowAsync(args, context.GetCancellationToken()).ConfigureAwait(false); |
There was a problem hiding this comment.
No need for async/await
There was a problem hiding this comment.
Same thing with templatePackageManager: we should await due to using. Forgot comment :)
| this.AddOption(CheckOnlyOption); | ||
| } | ||
|
|
||
| internal Option<bool> CheckOnlyOption { get; } = new("--check-only") |
There was a problem hiding this comment.
Should we consider "--dry-run"? Are there similar options in .NET SDK we could use same option?
There was a problem hiding this comment.
tool and workload doesn't have this feature, anything else?
I think we need to double check this name anyway, my first option was just --check but I'm not sure how clear it is. I will add --dry-run alias.
vlada-shubina
added a commit
to vlada-shubina/templating
that referenced
this pull request
Nov 22, 2021
* fixes dotnet/templating dotnet#3807 update subcommand
vlada-shubina
added a commit
that referenced
this pull request
Nov 26, 2021
* fixes dotnet/templating #3807 update subcommand
vlada-shubina
added a commit
that referenced
this pull request
Dec 21, 2021
* fixes dotnet/templating #3807 update subcommand
vlada-shubina
added a commit
to vlada-shubina/templating
that referenced
this pull request
Dec 23, 2021
* fixes dotnet/templating dotnet#3807 update subcommand
vlada-shubina
added a commit
that referenced
this pull request
Jan 11, 2022
* fixes dotnet/templating #3807 update subcommand
vlada-shubina
added a commit
that referenced
this pull request
Jan 27, 2022
* fixes dotnet/templating #3807 update subcommand
vlada-shubina
added a commit
that referenced
this pull request
Jan 28, 2022
* fixes dotnet/templating #3807 update subcommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fixes dotnet/templating #3807
Solution
implements update subcommand
Checks:
#nullable enableto all the modified files ?