Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS CI failure: "brew update" doesn't work in CI image; workaround causes openssl to be missing #1819

Closed
dagood opened this issue Oct 20, 2020 · 1 comment · Fixed by #1962
Closed

macOS CI failure: "brew update" doesn't work in CI image; workaround causes openssl to be missing #1819

dagood opened this issue Oct 20, 2020 · 1 comment · Fixed by #1962
Labels
area-testing Improvements in CI and testing blocking-clean-ci Blocking our core PR or CI builds

Comments

@dagood
Copy link
Member

dagood commented Oct 20, 2020

These occur in the Install native dependencies step in our macOS CI:

fatal: 'origin' does not appear to be a git repository
fatal: Could not read from remote repository.

Please make sure you have the correct access rights

Error: Fetching /usr/local/Homebrew/Library/Taps/local/homebrew-openssl failed!
Fetching /usr/local/Homebrew/Library/Taps/local/homebrew-python2 failed!
fatal: invalid upstream 'origin/master'
fatal: invalid upstream 'origin/master'

##[error]Bash exited with code '1'.

This is caused by a macOS CI image bug: actions/runner-images#1811

There is a workaround, but applying it causes the build to be unable to find openssl. More info in #1817 (master) and #1818 (release/3.1).
@dagood dagood added the area-testing Improvements in CI and testing label Oct 20, 2020
@dseefeld dseefeld mentioned this issue Oct 21, 2020
Merged
@dagood dagood added the blocking-clean-ci Blocking our core PR or CI builds label Oct 21, 2020
@dagood dagood mentioned this issue Oct 21, 2020
Merged
This was referenced Oct 21, 2020
Merged
Merged
@dagood dagood mentioned this issue Oct 26, 2020
Merged
@dagood dagood mentioned this issue Dec 7, 2020
Merged
@dagood
Copy link
Member Author

dagood commented Dec 7, 2020

The CI at #1925 failed later into the build than brew configuration. Maybe we can look at turning this back on.

omajid added a commit to omajid/dotnet-source-build that referenced this issue Jan 8, 2021
@omajid
Re-enable macOS CI
b563bca 
Enable the currently-commented out CI setup for macOS.

Fix the find command used for logger:

- Always specify path: the macOS version of find needs that or a -path
  argument to work.

- The regex engines differ between GNU find and macOS find. The `\|`
  part is parsed differently by both of them. Use a simpler regex that
  they can both support.

Use `TargetOverrideRid` (`osx-x64`) instead of `TargetRid`
(`osx.10.13-x64`) to determine the RID of the runtime tarball.

Fixes: dotnet#1819
@omajid omajid mentioned this issue Jan 8, 2021
Merged
omajid added a commit to omajid/dotnet-source-build that referenced this issue Jan 14, 2021
@omajid
Re-enable macOS CI
7df8a81 
Enable the currently-commented out CI setup for macOS.

Fix the find command used for logger:

- Always specify path: the macOS version of find needs that or a -path
  argument to work.

- The regex engines differ between GNU find and macOS find. The `\|`
  part is parsed differently by both of them. Use a simpler regex that
  they can both support.

Use `TargetOverrideRid` (`osx-x64`) instead of `TargetRid`
(`osx.10.13-x64`) to determine the RID of the runtime tarball.

Fixes: dotnet#1819
omajid added a commit to omajid/dotnet-source-build that referenced this issue Jan 18, 2021
@omajid
Re-enable macOS CI
8ac9185 
Enable the currently-commented out CI setup for macOS.

Fix the find command used for logger:

- Always specify path: the macOS version of find needs that or a -path
  argument to work.

- The regex engines differ between GNU find and macOS find. The `\|`
  part is parsed differently by both of them. Use a simpler regex that
  they can both support.

Use `TargetOverrideRid` (`osx-x64`) instead of `TargetRid`
(`osx.10.13-x64`) to determine the RID of the runtime tarball.

Fixes: dotnet#1819
dagood pushed a commit that referenced this issue Jan 19, 2021
@omajid
Re-enable macOS CI (#1962)
f47119a 
Enable the currently-commented out CI setup for macOS.

Fix the find command used for logger:

- Always specify path: the macOS version of find needs that or a -path
  argument to work.

- The regex engines differ between GNU find and macOS find. The `\|`
  part is parsed differently by both of them. Use a simpler regex that
  they can both support.

Use `TargetOverrideRid` (`osx-x64`) instead of `TargetRid`
(`osx.10.13-x64`) to determine the RID of the runtime tarball.

Fixes: #1819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-testing Improvements in CI and testing blocking-clean-ci Blocking our core PR or CI builds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable macOS CI omajid/dotnet-source-build
2 participants
@dseefeld @dagood