Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/aspnetcore #46926

Merged
merged 9 commits into from
Feb 20, 2025
Merged

[main] Update dependencies from dotnet/aspnetcore #46926

merged 9 commits into from
Feb 20, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 18, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

  • Subscription: 4491d9a4-839d-4af5-f3e4-08d8e97c775d
  • Build: 20250219.6
  • Date Produced: February 20, 2025 2:29:37 AM UTC
  • Commit: 512209d2ccd8df506b3c302385fa840ff09d76d7
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
d749a21 
…0250218.3

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25118.3
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels Feb 18, 2025
@dotnet-maestro DotNet Maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/dotnet/aspnetcore:

@dotnet/aspnet-build

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/aspnetcore) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@build-analysis build-analysis bot mentioned this pull request Feb 19, 2025
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
527e45a 
…0250218.6

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25118.6
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
80becf7 
…0250218.7

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25118.7
This was referenced Feb 19, 2025
Open
Open
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
11d38e9 
…0250218.8

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25118.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
8bfe342 
…0250218.9

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25118.9
@build-analysis build-analysis bot mentioned this pull request Feb 19, 2025
Open
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
ca63e84 
…0250218.10

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25118.10
@v-wuzhai
Copy link
Member

@dotnet/source-build @dotnet/product-construction PTAL

@ViktorHofer ViktorHofer requested review from a team as code owners February 19, 2025 09:44
@ViktorHofer ViktorHofer enabled auto-merge (squash) February 19, 2025 09:44
@ViktorHofer
Copy link
Member

ViktorHofer commented Feb 19, 2025 •
edited
Loading

I think this change causes the issues that are now showing up on CI. BUT, the change itself is correct, we just weren't correctly handling this case before in aspnetcore. Arcade has a target that makes sure that RID specific applications only target the RID for the current VMR vertical and it looks like that without the above change, that target didn't ran because it wasn't hooked up.

cc @jkoritzinsky @NikolaMilosavljevic @wtgodbe

@nagilson
Copy link
Member

@dotnet/product-construction

src\aspnetcore\src\Tools\dotnet-sql-cache\src\dotnet-sql-cache.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.NETCore.App.Host.win-x86 with version (= 10.0.0-ci)

It looks like this project can't find a .NET 10 runtime, what should we do here?

@nagilson
Copy link
Member

CanIgnoreTemplateGroupsWithConstraints this also failed, expecting [foo] but got [], but this is only once. I assume its transient.

@nagilson nagilson removed the untriaged Request triage from a team member label Feb 19, 2025
@NikolaMilosavljevic
Copy link
Member

I think this change causes the issues that are now showing up on CI. BUT, the change itself is correct, we just weren't correctly handling this case before in aspnetcore. Arcade has a target that makes sure that RID specific applications only target the RID for the current VMR vertical and it looks like that without the above change, that target didn't ran because it wasn't hooked up.

cc @jkoritzinsky @NikolaMilosavljevic @wtgodbe

Hmm, this is interesting - I'm not sure why we're seeing these errors as proper packages should be built on Windows:

src\aspnetcore\src\Tools\dotnet-sql-cache\src\dotnet-sql-cache.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.NETCore.App.Host.win-x86 with version (= 10.0.0-ci)
  - Found 1458 version(s) in dotnet8 [ Nearest version: 8.0.0-rtm.23523.3 ]
  - Found 1417 version(s) in dotnet9 [ Nearest version: 9.0.0-rtm.24516.5 ]

Will get a local repro to investigate.

@jkoritzinsky
Copy link
Member

My guess is that we aren't overriding the PackAsToolShimRuntimeIdentifiers property correctly in the logic, or it's getting overwritten after our logic runs.

@NikolaMilosavljevic I think if you change the logic in aspnetcore to only pack the current RID instead of win-64;win-86 that will unblock the build.

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Feb 19, 2025 •
edited
Loading

My guess is that we aren't overriding the PackAsToolShimRuntimeIdentifiers property correctly in the logic, or it's getting overwritten after our logic runs.

@NikolaMilosavljevic I think if you change the logic in aspnetcore to only pack the current RID instead of win-64;win-86 that will unblock the build.

That change would be made in aspnetcore and flow into this PR. I'm curious why both architectures are apparently required based on this comment: https://github.com/dotnet/aspnetcore/blob/e2151836317a0d027bf06680c59474086268c8af/src/Tools/Directory.Build.targets#L3

Current VMR builds are not setting PackAsToolShimRuntimeIdentifiers in these projects.

Two options:

@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Feb 19, 2025
Merged
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
d9ba940 
…0250219.2

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25119.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/aspnetcore build 2…
293dfca 
…0250219.6

dotnet-dev-certs , dotnet-user-jwts , dotnet-user-secrets , Microsoft.AspNetCore.Analyzers , Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Ref.Internal , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Authentication.Facebook , Microsoft.AspNetCore.Authentication.Google , Microsoft.AspNetCore.Authentication.MicrosoftAccount , Microsoft.AspNetCore.Authorization , Microsoft.AspNetCore.Components , Microsoft.AspNetCore.Components.Analyzers , Microsoft.AspNetCore.Components.Forms , Microsoft.AspNetCore.Components.SdkAnalyzers , Microsoft.AspNetCore.Components.Web , Microsoft.AspNetCore.Components.WebAssembly , Microsoft.AspNetCore.Components.WebAssembly.Server , Microsoft.AspNetCore.Components.WebView , Microsoft.AspNetCore.DeveloperCertificates.XPlat , Microsoft.AspNetCore.Metadata , Microsoft.AspNetCore.Mvc.Analyzers , Microsoft.AspNetCore.Mvc.Api.Analyzers , Microsoft.AspNetCore.TestHost , Microsoft.DotNet.Web.ItemTemplates.10.0 , Microsoft.DotNet.Web.ProjectTemplates.10.0 , Microsoft.Extensions.FileProviders.Embedded , Microsoft.Extensions.ObjectPool , Microsoft.JSInterop , VS.Redist.Common.AspNetCore.SharedFramework.x64.10.0 , Microsoft.SourceBuild.Intermediate.aspnetcore
 From Version 10.0.0-preview.2.25114.1 -> To Version 10.0.0-preview.2.25119.6
@ViktorHofer ViktorHofer merged commit 1b98071 into main Feb 20, 2025
43 of 44 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-e0b25909-a267-4179-980b-1ab629abbe33 branch February 20, 2025 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-CodeFlow Area-VMR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-wuzhai @ViktorHofer @nagilson @NikolaMilosavljevic @jkoritzinsky