Set PDB artifacts dir for VMR inter-build storage #46800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
mmitche
commented
Feb 12, 2025
| @@ -19,11 +19,13 @@ | |||
| <RepoArtifactsShippingPackagesDir Condition="'$(ReferenceOnlyRepoArtifacts)' == 'true'">$(ReferencePackagesDir)</RepoArtifactsShippingPackagesDir> | |||
| <RepoArtifactsNonShippingPackagesDir Condition="'$(ReferenceOnlyRepoArtifacts)' != 'true'">$([MSBuild]::NormalizeDirectory('$(ArtifactsNonShippingPackagesDir)', '$(RepositoryName)'))</RepoArtifactsNonShippingPackagesDir> | |||
| <RepoArtifactsNonShippingPackagesDir Condition="'$(ReferenceOnlyRepoArtifacts)' == 'true'">$(ReferencePackagesDir)</RepoArtifactsNonShippingPackagesDir> | |||
| <RepoArtifactsPdbArtifactsDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsSymStoreDirectory)', '$(RepositoryName)'))</RepoArtifactsPdbArtifactsDir> | |||
|
|
|||
| <!-- Pass location for packages --> | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltShippingPackagesDir=$(RepoArtifactsShippingPackagesDir)</BuildArgs> | |||
| <!-- Trim the trailing slash as it breaks argument parsing on Windows if this is the last argument. --> | |||
| <BuildArgs>$(BuildArgs) /p:SourceBuiltNonShippingPackagesDir=$(RepoArtifactsNonShippingPackagesDir.TrimEnd('\'))</BuildArgs> | |||
There was a problem hiding this comment.
@jkoritzinsky Any idea why we trim the trailing slash on this but not the shipping packages?
There was a problem hiding this comment.
It was probably the last argument at some point, which caused issues on Windows because of \". It would be more consistent to do this on the shipping packages dir property as well.
There was a problem hiding this comment.
Yeah I bet it was the last argument at the time.
ViktorHofer
reviewed
Feb 13, 2025
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer
approved these changes
Feb 13, 2025
jkoritzinsky
approved these changes
Feb 13, 2025
ViktorHofer
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for https://github.com/dotnet/arcade/pull/15497/files/e3fafa02f4378abbbd13daa6dec63d51330c7452#diff-2c204b59d01e73c04c5834f945685c3f74bbe862e33de4b58cd2ebc47f200cd1R326