Remove vertical priority list #46741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've deduped our assets, we can get rid of the priority list and get back to one "main" vertical.
mmitche
approved these changes
Feb 12, 2025
ViktorHofer
approved these changes
Feb 12, 2025
|
Do you also want to remove the infra support for the prio list? I assume that only supporting one primary vertical will simplify the code a bit. |
|
I was thinking of holding off on removing the infra until we get rid of the concept of a "primary" vertical, but based on the test failures it might be worth just doing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've deduped our assets, we can get rid of the priority list and get back to one "main" vertical.
Depends on #46730