[main] Update dependencies from dotnet/roslyn

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/roslyn

• Subscription: d5dc2a0a-0871-47fc-022d-08dc4502ccaa
• Build: 20250212.6
• Date Produced: February 12, 2025 11:36:33 PM UTC
• Commit: 36036f8f7458b5da58207b579e326608efc86bdf
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.roslyn: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis.CSharp: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis.CSharp.CodeStyle: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis.CSharp.Features: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis.CSharp.Workspaces: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis.Workspaces.Common: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.CodeAnalysis.Workspaces.MSBuild: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.Net.Compilers.Toolset: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6
  • Microsoft.Net.Compilers.Toolset.Framework: from 4.14.0-1.25070.2 to 4.14.0-2.25112.6

[dotnet-maestro]

Notification for subscribed users from https://github.com/dotnet/roslyn:

@dotnet/roslyn-infrastructure-current-swat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

• This pull request contains changes from your source repo (https://github.com/dotnet/roslyn) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
• If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
• For more details, please read the Arcade Darc documentation

[akoeplinger]

darc lost track of old PRs so it opened this new one, this is currently blocked as explained in #46195

[ViktorHofer]

@jjonescz @jaredpar what is the right team to tag here? The dotnet/roslyn GH team has 64 members so I didn't cc that. See build failures:

src/roslyn/src/Features/ExternalAccess/Copilot/Analyzer/CopilotUtilities.cs(25,43): error CS0433: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'NotNullWhenAttribute' exists in both 'Microsoft.CodeAnalysis.Workspaces, Version=4.14.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' and 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'

[jjonescz]

what is the right team to tag here?

if you mean in general instead of @dotnet/roslyn-infrastructure-current-swat which was removed, that should be probably replaced with @dotnet/roslyn-infrastructure

if you mean roslyn/src/Features specifically, that's owned by @dotnet/roslyn-ide

[333fred]

@dotnet/product-construction @jaredpar @genlu, this was broken by dotnet/roslyn@f3ef599. Previously, the Copilot EA was in the EditorFeatures layer, which meant that it was excluded from source-build. Now, it's in the Features layer, which is not excluded from source build, which has the following impact:

• NetRoslynSourceBuild is set to net10.0. This means that Workspaces is built for both net10.0 and netstandard2.0.
• The Copilot EA has a TFM of $(NetVSShared);net472, which evaluates to net8.0;net472. So it picks up the netstandard2.0 version of Workspaces, which defines an internal copy of NotNullWhenAttribute.
• We build Copilot for net8.0, and since it has IVT to Workspaces, it sees both the copy from the framework and from Workspaces, resulting in this error.

dotnet/roslyn#77136 will turn off building this EA assembly in source-build, since we shouldn't be doing that in the first place.

[ViktorHofer]

So, the remaining failure now is IDE0060 again as in #46353 (comment)

@sharwell please reply to @jaredpar's question. Do we have a tracking issue? @DustinCampbell shared repro instructions which should help. Please prioritize this as roslyn is already more than 500 commits old in main.

[carlossanlop]

There are unknown failures in VMR with the message Failed to synchronize the VMR. Who's the best person to look into them?

[ViktorHofer]

FYI @sharwell and @CyrusNajmabadi are investigating the remaining IDE0060 issue offline. We have a Teams thread about this.

[MichaelSimons]

There are unknown failures in VMR with the message Failed to synchronize the VMR. Who's the best person to look into them?

There was a VMR patch that was backported and flowing in. I removed the patch to address the problem.

@dotnet/product-construction is the appropriate team to ping on issues like this.