Don't double pack icon in our transport package #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livarcocc
approved these changes
Nov 13, 2019
rainersigwald
approved these changes
Nov 13, 2019
wli3
pushed a commit
to wli3/sdk
that referenced
this pull request
Dec 13, 2019
wli3
pushed a commit
to wli3/sdk
that referenced
this pull request
Dec 13, 2019
wli3
pushed a commit
to wli3/sdk
that referenced
this pull request
Dec 13, 2019
wli3
pushed a commit
that referenced
this pull request
Dec 13, 2019
Don't double pack icon in our transport package (#3906)
wli3
pushed a commit
that referenced
this pull request
Dec 13, 2019
Don't double pack icon in our transport package (#3906)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently holding up sdk -> toolset code flow for 5.0/master
Arcade is adding an icon entry to package, then our custom targets are laying this out and then globbing and packing the layout.
The fix is to ignore the icon file from the custom layout process in our build.