[NativeAOT-LLVM] Fix most warnings for the HelloWasm runtime test
#2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two throw helpers used for tentative methods: "ThrowBodyRemoved" and "ThrowInstanceBodyRemoved". We were always using the first one.
We import them manually from a shared location. Usually this is not a problem because batch build (via the build script) does its own restore thing, but it is a problem in case the project is restored on its own, such as when it is built with "dotnet build".
|
@dotnet/nativeaot-llvm |
yowl
approved these changes
Jan 13, 2023
| @@ -35,11 +35,11 @@ public TentativeInstanceMethodNode(IMethodBodyNode methodNode) | |||
|
|
|||
| public override bool HasConditionalStaticDependencies => true; | |||
|
|
|||
| protected override ISymbolNode GetTarget(NodeFactory factory) | |||
| public override IMethodNode GetTarget(NodeFactory factory) | |||
There was a problem hiding this comment.
This visibility change seems harmless to me, but maybe @jkotas you'd like to cast an eye on it?
There was a problem hiding this comment.
It looks good to me. @MichalStrehovsky Any concerns?
There was a problem hiding this comment.
Nope, looks good. All AssemblyStubNode descendants need some special treatment because on WASM we're not able to generate byte buffers with extra code in it (which is what we do elsewhere).
SingleAccretion
changed the title
HelloWasm runtime testHelloWasm runtime test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only two, related to the missing
dotnet_browser_entropysymbol, remain.Contributes to #2165.