-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Fix FormatQuantiles formatting in MetricsEventSource #99045
[release/8.0-staging] Fix FormatQuantiles formatting in MetricsEventSource #99045
Conversation
These doubles need to be formatted with the invariant culture to meet consumer expectations around parsing them.
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsBackport of #98699 to release/8.0-staging /cc @stephentoub Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.] Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.] Testing[How was the fix verified? How was the issue missed previously? What tests were added?] Risk[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.] IMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephentoub please ensure adding the package authoring to this change.
I went ahead and added the servicing changes with the web editor. |
Friendly reminder that Monday March 11th is the Code Complete date for the April Release. This PR still needs the package authoring changes requested above. |
Is that different from what @ericstj added already? |
My bad. It's ready to merge then. |
Build Analysis is red. I don't think those test failures are related to this, but can you confirm you've seen those same failures on other 8.0-staging PRs? |
Ok, thanks. |
Backport of #98699 to release/8.0-staging
/cc @stephentoub
Customer Impact
dotnet counters displays corrupted values when the application being monitored is running under certain cultures, like Finnish (Finland).
Regression
Regression introduced in .NET 8 as part of changes to add CompositeFormat. A line was erroneously changed to remove using the invariant culture when formatting a string and instead use the current culture.
Testing
New tests were added to validate the metrics event source is appropriately outputting the expected data under various cultures.
Risk
Low. The code was effectively restored to what it was previously using invariant culture instead of current culture.