-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that ICU is loaded in tests before checking its version #96288
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Detailsnull
|
Could be #96187 Presumably, It changed behavior for "Checked" config? |
Yeah, bisect for sure is pointing to 476a455, it doesn't make a lot of sense to me but it is 🙂 (or maybe it's flaky?) |
Thank you running the bisect locally! If 476a455 is the problem, it is likely that removing the eager initialization from the static constructor exposes a latent bug in the rest of the static constructor. I have pushed a delta to confirm or disprove this theory. |
Tagging subscribers to this area: @dotnet/area-system-globalization Issue Detailsnull
|
The change removed ICU initialization as a side-effect that caused ICU version detection in other tests to fail silently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, now it makes sense. Is try-catch necessary there?
Or if it fails you want some specific test to fail rather than internally in xunit?
I have moved it into the existing try/catch. |
Fixes #96279