Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono][interp] Add Vector128.EqualsAny simd intrinsic #95901

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[mono][interp] Add Vector128.EqualsAny simd intrinsic #95901

merged 2 commits into from
Dec 12, 2023

Conversation

BrzVlad
Copy link
Member

@BrzVlad BrzVlad commented Dec 12, 2023 •
edited
Loading

@BrzVlad
[mono][interp] Add vectorization for EqualsAny
e0802f5
@BrzVlad
[mono][interp] Replace br + ret with ret
204d5a3 
It is quite common for code to branch to a instruction returning from the method. Emit a directly a return instead.
@ghost ghost assigned BrzVlad Dec 12, 2023
@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: BrzVlad
Assignees: -
Labels:

area-Codegen-Interpreter-mono
Milestone: -

@BrzVlad BrzVlad mentioned this pull request Dec 12, 2023
Closed
@lewing lewing merged commit cfa49f6 into dotnet:main Dec 12, 2023
@SamMonoRT
Copy link
Member

cc @tannergooding

@tannergooding
Copy link
Member

Thanks! This should unblock other work in the area

@lewing lewing mentioned this pull request Dec 14, 2023
Open
@kotlarmilos kotlarmilos mentioned this pull request Dec 19, 2023
Closed
@fanyang-mono
Copy link
Member

There are still other Vector128 API's not supported by interpreters, such as EqualsAll. Please consider supporting them as well. The full list of Vector128 API can be found at https://github.com/dotnet/runtime/blob/main/src/mono/mono/mini/simd-intrinsics.c#L1175

@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vargaz vargaz vargaz approved these changes

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos kotlarmilos is a code owner

Assignees

@BrzVlad BrzVlad

Labels
area-Codegen-Interpreter-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Perf] Linux/x64: 14 Regressions on 10/3/2023 8:04:03 PM
6 participants
@BrzVlad @SamMonoRT @tannergooding @fanyang-mono @vargaz @lewing