Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] move files around #92429

Closed
wants to merge 4 commits into from
Closed

[browser] move files around #92429

wants to merge 4 commits into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 21, 2023 •
edited
Loading

Introducing directories

  • core
  • jiterpreter
  • interop

and moving TS files into them.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Sep 21, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Sep 21, 2023
@pavelsavara pavelsavara requested a review from maraf September 21, 2023 19:08
@pavelsavara pavelsavara self-assigned this Sep 21, 2023
@ghost
Copy link

ghost commented Sep 21, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser
Milestone: 9.0.0

@pavelsavara pavelsavara force-pushed the browser_ts_directories branch from 727913b to 8c0ac57 Compare September 21, 2023 19:37
@campersau
Copy link
Contributor

I guess this is going to conflict with #91699

@pavelsavara
more
737da53
@pavelsavara
Merge branch 'main' into browser_ts_directories
9cd2a74 
# Conflicts:
#	src/mono/wasm/runtime/core/http.ts
@pavelsavara
Copy link
Member Author

I guess this is going to conflict with #91699

It was not that bad :)

@build-analysis build-analysis bot mentioned this pull request Sep 21, 2023
Closed
@pavelsavara pavelsavara marked this pull request as ready for review September 22, 2023 05:31
@maraf
Copy link
Member

maraf commented Sep 22, 2023

What about splitting the code by module?

  • runtime
    • diagnostics
    • jiterpreter
    • ...
  • loader
    • run.ts
    • ...
  • emscripten
    • dotnet.lib.js
    • dotnet.pre.js
    • ...

What about moving typescript/js code to a separate folde (like client/client-side)?

@pavelsavara
Copy link
Member Author

What about splitting the code by module?

That's exactly the idea, and we could do better than I did so far.

I did core for dotnet.runtime.js because I didn't like runtime/runtime folder. We could rename the outer folder.

Rename of es6 to emscripten is good idea, I forgot about that. But maybe we could do native instead.

@pavelsavara
Copy link
Member Author

I need to work on something else ... maybe later

This was referenced Sep 22, 2023
Open
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2023
@pavelsavara pavelsavara deleted the browser_ts_directories branch September 2, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg kg is a code owner

@radical radical Awaiting requested review from radical

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @campersau @maraf