-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Add some convenience classes for node count JIT metrics, and automatic dumping from compShutdown #92112
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2bad3e1
JIT: Add some convenience classes for ad-hoc JIT metrics
jakobbotsch 0a2730c
Add some example usage comments
jakobbotsch 60dd0a6
Merge branch 'main' of github.com:dotnet/runtime into jit-adhoc-metrics
jakobbotsch 7f95aa3
Fix after merge
jakobbotsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX | |
#endif | ||
|
||
#include "opcode.h" | ||
#include "jitstd/algorithm.h" | ||
|
||
/*****************************************************************************/ | ||
|
||
|
@@ -999,6 +1000,90 @@ void Histogram::record(unsigned size) | |
m_counts[i]++; | ||
} | ||
|
||
void NodeCounts::dump(FILE* output) | ||
{ | ||
struct Entry | ||
{ | ||
genTreeOps oper; | ||
unsigned count; | ||
}; | ||
|
||
Entry sorted[GT_COUNT]; | ||
for (int i = 0; i < GT_COUNT; i++) | ||
{ | ||
sorted[i].oper = static_cast<genTreeOps>(i); | ||
sorted[i].count = m_counts[i]; | ||
} | ||
|
||
jitstd::sort(sorted, sorted + ArrLen(sorted), [](const Entry& lhs, const Entry& rhs) { | ||
if (lhs.count > rhs.count) | ||
{ | ||
return true; | ||
} | ||
|
||
if (lhs.count < rhs.count) | ||
{ | ||
return false; | ||
} | ||
|
||
return static_cast<unsigned>(lhs.oper) < static_cast<unsigned>(rhs.oper); | ||
}); | ||
|
||
for (const Entry& entry : sorted) | ||
{ | ||
if (entry.count == 0) | ||
{ | ||
break; | ||
} | ||
|
||
fprintf(output, "%-20s : %7u\n", GenTree::OpName(entry.oper), entry.count); | ||
} | ||
} | ||
|
||
void NodeCounts::record(genTreeOps oper) | ||
{ | ||
assert(oper < GT_COUNT); | ||
m_counts[oper]++; | ||
} | ||
|
||
struct DumpOnShutdownEntry | ||
{ | ||
const char* Name; | ||
Dumpable* Dumpable; | ||
}; | ||
|
||
static DumpOnShutdownEntry s_dumpOnShutdown[16]; | ||
|
||
DumpOnShutdown::DumpOnShutdown(const char* name, Dumpable* dumpable) | ||
{ | ||
for (DumpOnShutdownEntry& entry : s_dumpOnShutdown) | ||
{ | ||
if ((entry.Name == nullptr) && (entry.Dumpable == nullptr)) | ||
{ | ||
entry.Name = name; | ||
entry.Dumpable = dumpable; | ||
break; | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe add an assert that the DumpOnShutdownEntry table isn't all full? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do. |
||
} | ||
|
||
void DumpOnShutdown::DumpAll(FILE* fout) | ||
{ | ||
for (const DumpOnShutdownEntry& entry : s_dumpOnShutdown) | ||
{ | ||
if (entry.Name != nullptr) | ||
{ | ||
fprintf(fout, "%s\n", entry.Name); | ||
} | ||
|
||
if (entry.Dumpable != nullptr) | ||
{ | ||
entry.Dumpable->dump(fout); | ||
fprintf(fout, "\n"); | ||
} | ||
} | ||
} | ||
|
||
#endif // CALL_ARG_STATS || COUNT_BASIC_BLOCKS || COUNT_LOOPS || EMITTER_STATS || MEASURE_NODE_SIZE | ||
|
||
/***************************************************************************** | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this do an interlocked add?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that would depend on whether this class is instantiated as global, or as a member of Compiler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for good measure it should be interlocked add.
NodeCounts
is meant to be used as a static field (likeHistogram
) so you can collect stats for multiple compilations, so it can be racing with other threads, although I expect we mainly use it through SPMI where it won't due to the way parallelization works there.Looks like
Histogram
should also be changed to use an interlocked add.