Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix old gcc build #91845

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix old gcc build #91845

merged 1 commit into from
Oct 9, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Sep 9, 2023 •
edited
Loading

gcc 4.9 builds coreclr with this patch.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 9, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 9, 2023
@ghost
Copy link

ghost commented Sep 9, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: am11
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@am11 am11 added area-Infrastructure-coreclr and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Sep 9, 2023
@ghost
Copy link

ghost commented Sep 9, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

gcc 4.9 builds coreclr with this patch.

Author: am11
Assignees: -
Labels:

area-Infrastructure-coreclr, community-contribution
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Sep 9, 2023
Closed
janvorli
janvorli approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@agocke agocke merged commit 94f2122 into dotnet:main Oct 9, 2023
@agocke
Copy link
Member

agocke commented Oct 9, 2023

Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments

@janvorli janvorli janvorli approved these changes

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@am11 @agocke @jakobbotsch @janvorli @AaronRobinsonMSFT