[mono][aot] Deferred failures code cleanup #86998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kotlarmilos
requested review from
vargaz,
lambdageek,
SamMonoRT and
thaystg
as code owners
vargaz
reviewed
Jun 1, 2023
lambdageek
reviewed
Jun 1, 2023
lambdageek
approved these changes
Jun 1, 2023
vargaz
reviewed
Jun 1, 2023
| * @returns: TRUE if the failure is handled and the runtime should not proceed with class setup, FALSE if the failure should be deferred for runtime class setup. | ||
| * | ||
| */ | ||
| typedef gboolean (*TypeLoadFailureCallback)(MonoClass *klass, const char * fmt, ...) MONO_ATTR_FORMAT_PRINTF(2,3); |
There was a problem hiding this comment.
There is a MonoRuntimeCallbacks structure in object-internals.h which could include this.
There was a problem hiding this comment.
I like the idea. I've moved it and added checks if the callback is initialized, like
if (mono_get_runtime_callbacks ()->mono_class_set_deferred_type_load_failure_callback)
|
I've added to |
vargaz
approved these changes
Jun 1, 2023
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failures are known and shouldn't be related. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
mono_prefix for functions and types, and moves code related to class manipulation to themono/metadatadirectory.