Add adjacency row length check in System.Text.Json Topological Sort #86716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsThe added check is purely code correctness, the current call sites invoke the method with parameters not triggering a possible IndexOutOfRangeException. Fixes #86702
|
Tornhoof
commented
May 24, 2023
| @@ -133,7 +133,7 @@ public static T[] TraverseGraphWithTopologicalSort<T>(T entryNode, Func<T, IColl | |||
| // Iterate over the adjacency matrix, removing any occurrence of nextIndex. | |||
| for (int i = 0; i < adjacency.Count; i++) | |||
| { | |||
| if (adjacency[i] is { } childMap && childMap[nextIndex]) | |||
| if (adjacency[i] is { } childMap && nextIndex < childMap.Length && childMap[nextIndex]) | |||
There was a problem hiding this comment.
It is not possible to build a type hierarchy with interfaces which triggers this, as GetInterfaces and AllInterfaces return the complete list of inherited and implemented interfaces and not only the directly implemented ones.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added check is purely code correctness, the current call sites invoke the method with parameters not triggering a possible IndexOutOfRangeException.
Fixes #86702