Use the BannedApiAnalyzer instead of the LinqPoison mechanism to ban Linq in the managed type system #86673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsInstead of using a symbol collision with a comment block to stop people from using LINQ in the managed type system, use the BannedApiAnalyzer to ban the Linq namespace in a more standard fashion. Also update the BannedApiAnalyzer package to a version that has namespace support to allow us to enforce it (it was recently merged in).
|
MichalStrehovsky
approved these changes
May 24, 2023
|
OSX failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a symbol collision with a comment block to stop people from using LINQ in the managed type system, use the BannedApiAnalyzer to ban the Linq namespace in a more standard fashion. Also update the BannedApiAnalyzer package to a version that has namespace support to allow us to enforce it (it was recently merged in).